• @guqing guqing created a review on pull request #6378 in halo-dev/halo

    /lgtm

    0 0
  • @guqing guqing commented on pull request #6364 in halo-dev/halo

    同时这里应该需要定义一个 rules 在附件相关的角色模板中,否则此 API 只能允许超级管理员调用

    0 0
  • @guqing guqing commented on pull request #6364 in halo-dev/halo
        Mono<ResponseEntity<Void>> head(URI uri);
    
    0 0
  • @guqing guqing commented on pull request #6364 in halo-dev/halo

    校验 mediaType 只允许图片和视频

    0 0
  • @guqing guqing commented on pull request #6364 in halo-dev/halo

    建议增加对文件大小的限制,同时需要考虑请求中途被取消的情况(如上传时间长用户手动取消)这里的 upload 我不确定在这种情况下是什么行为

    0 0
  • @guqing guqing commented on pull request #6364 in halo-dev/halo

    建议目前只允许转存图片和视频,需要校验一下文件类型

    0 0
  • @guqing guqing commented on pull request #6364 in halo-dev/halo

    这里是否需要对提示信息国际化

    0 0
  • @guqing guqing commented on pull request #6364 in halo-dev/halo
                    throw new ServerWebInputException("Required url is missing.");
    
    0 0
  • @guqing guqing commented on pull request #6364 in halo-dev/halo
                if (!StringUtils.hasText(url)) {
    
    0 0
  • @guqing guqing commented on pull request #6364 in halo-dev/halo
        public record ExternalTransferRequest(@Schema(requiredMode = REQUIRED) URL url,
    
    0 0